Skip to content

feat: install.sh that installs or updates pullgate from a checked release - #10

Merged
groupsky merged 2 commits into
mainfrom
feat/install-sh
Nov 12, 2026
Merged

groupsky merged 2 commits into
mainfrom
feat/install-sh

Conversation

@groupsky

@groupsky groupsky commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Closes nothing yet: part of #7. Its last "Done when" box (a real run against a release) waits for the first release.

install.sh in the repository root installs or updates pullgate from a release. It installs nothing unless every check passes: the SHA-256 in SHA256SUMS, gh attestation verify with the release workflow identity, and the version the new binary prints.

Progress

  • install.sh (POSIX sh, clean environment, root-only paths, amd64/arm64, size limits, pinned gh, atomic rename, exit codes 0/1/64)
  • Tests against a fake release: TestInstallDenies/*, TestInstall, TestInstallNothingToDo, TestInstallUsage, TestInstallReplaces, TestInstallDownloadsGh, and more
  • ShellCheck v0.11.0 in CI (pinned, SHA-256 checked)
  • THREAT-MODEL.md T17, DESIGN.md section 16, README "Install"
  • Security review (subagent), findings fixed
  • Final security review and correctness review on this diff; fixed: signal last line, early GNU timeout check, tests fail (not skip) as root in CI, sed in README, sticky-bit note in T17
  • After the first release: a real run (in feat: install.sh that installs or updates pullgate from a checked release #7)

Findings not fixed

  • The script does not restart itself under env -i; the README shows how to start it with a clean environment, and T17 says the cleaned variables are a block list.
  • No test sends a signal after the rename (hard to time in a test). The last line then says the file may be installed.
  • The README downloads the script from main, as feat: install.sh that installs or updates pullgate from a checked release #7 says; it also says how to use a tag instead.

🤖 Generated with Claude Code

groupsky and others added 2 commits November 12, 2026 19:46
…ease

Refs #7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A signal says in the last line whether the new file was installed; an
early check for GNU timeout; tests fail instead of skip as root in CI;
docs: sed is needed, the sticky-bit exception in T17.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@groupsky
groupsky marked this pull request as ready for review November 12, 2026 17:52
@groupsky
groupsky merged commit dd7638d into main Nov 12, 2026
9 checks passed
@groupsky
groupsky deleted the feat/install-sh branch November 12, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant