Skip to content

docs: releasing.md asks for a required reviewer that would gate every push to main #5

Closed

Description

@groupsky

docs/releasing.md, "One-time setup" step 3, says: add the owner as a required reviewer of the release environment.

The release-please job uses this environment, and it runs on every push to main. With a required reviewer, every merge to main would wait for an approval in the Actions page, not only releases. The owner decided on 2026-11-11 not to add a reviewer (nodkey has none either). Releases are still gated: only the owner merges the release pull request.

Change the docs to match the real setting.

Done when

  • docs/releasing.md no longer asks for a required reviewer on the release environment.
  • It says in one or two sentences why there is none: the environment is used on every push to main, and the gate is the merge of the release PR, done only by the owner.
  • Nothing else in the repo (README, AGENTS.md, THREAT-MODEL.md, workflow comments) still says the release environment has a required reviewer (grep -rni reviewer).
  • The PR title is docs: …, so it shows in the release notes.

Activity

  1. groupsky commented on Nov 12, 2026

    @groupsky
    ContributorAuthor

    Done in #12 (8cc4e3a, title docs: releasing.md stands alone and asks for no required reviewer).

    • docs/releasing.md no longer asks for a required reviewer. Section "One-time setup" ends with why there is none: the release environment is used on every push to main; the gate is the merge of the release PR, done only by the owner.
    • git grep -ni reviewer on main: only that paragraph, and the security-reviewer agent (a different thing).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: lowDo when nothing else waits

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions