Repository navigation
fix(broker): send start alerts at the same time, so a stop stays clean - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Start alerts (a torn audit line found at start, a failed store) were sent one after another, and each first try can take up to 30 s. With 3 queued alerts and a Telegram that does not answer, a SIGTERM right after the start hit the broker's 80 s stop limit: the broker exited 1 without writing
broker_stopped.alert=N. A panic in one alert does not stop the others, and its value is not logged.Tests
TestStartAlertsAtTheSameTime(synctest with the real 30 s and 80 s limits: a clean stop after exactly 30 s; the old code gave up at 1m20s),TestStartAlertsTryAgain,TestStartAlertPanics, and two tests with the real broker in a child process: a SIGTERM with three unanswered alerts stops cleanly withbroker_stopped, and each alert goes out exactly once when Telegram comes back. All fail with the old code.Docs
DESIGN.md section 15.
Review
One round with the security-reviewer agent: "ready to commit".
Closes #59