Repository navigation
chore(deps): bump go.opentelemetry.io/otel/trace from 1.44.0 to 1.47.0 - #184
Merged
Merged
Conversation
OpenSSH 10 sshd (ubuntu-26.04 runners) no longer offers diffie-hellman-group16-sha512 and diffie-hellman-group-exchange-sha256 by default, so TestSSHDMatrix could not negotiate them.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
go.opentelemetry.io/otel/tracegoes from 1.44.0 to 1.47.0, with the related indirect modules. nodkey imports no otel package; it comes in through the store SDKs.internal/sshauth/sshd_test.go:TestSSHDMatrixgets ansshdOptsfield. The two finite-field Diffie-Hellman cases (diffie-hellman-group16-sha512anddiffie-hellman-group-exchange-sha256) now addKexAlgorithms +<alg>to the test sshd's config.Why #183 was held
CI was red:
TestSSHDMatrixfailed for those two cases with "no matching key exchange method found". The update did not cause it. The CI run of #183 (2026-11-14) ran onubuntu-26.04with OpenSSH 10.2. The last green CI run ofmain(2026-11-13) ran onubuntu-24.04. The sshd of OpenSSH 10 does not offer these DH key exchanges by default anymore.How this fixes it
The test sshd now turns on the one key exchange that each case tests. The client still allows only that one (
KexAlgorithms=<alg>), so the test still proves the same thing. No product code changes.go test -race ./...,go vet ./...andgolangci-lint run --build-tags e2epass locally (OpenSSH 9.6). The security review found nothing.Supersedes #183
Refs #146
🤖 Generated with Claude Code