Repository navigation
feat: nodkey agent-browser-plugin, the credential plugin for agent-browser (#104) - #182
Merged
Merged
Conversation
…owser (#104) - nodkey agent-browser-plugin speaks agent-browser.plugin.v1: credential.resolve, nodkey.list, nodkey.totp, plugin.manifest. - New header Nodkey-No-Tap on /v1/logins/login: no message; 428 and the audit cause no_tap when no grant or pre-approval covers it. - Contract test with requests recorded from agent-browser 0.38.1. - DESIGN.md 21.10, THREAT-MODEL.md T48, docs/agent-browser.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of #104 (the issue stays open for the end-to-end test of the
agentsChrome profile).What
nodkey agent-browser-plugin: the credential plugin of agent-browser (protocolagent-browser.plugin.v1). It answerscredential.resolve,nodkey.list,nodkey.totpandplugin.manifest. It is anodkeysubcommand, so it ships in the same signed release (feat: a nodkey credential plugin for agent-browser logins #104 open question 4).Nodkey-No-Tap: 1on/v1/logins/login. With it the broker never asks the person. When no window grant and no one-use pre-approval covers the login, it answers 428 at once, with adeniedentry with the new causeno_tap, and sends no message. All checks of a login still run. agent-browser waits only 15 s for a plugin, so the tap comes first, innodkey preapprove --login.internal/client/testdata/agent-browser-0.38.1/), to a real test broker with a fakebwstore.docs/agent-browser.md(plugin entry, login steps, TOTP, errors, theagentsChrome profile, marked as not yet tested from start to end);docs/setup.mdpoints to it.Decisions (from the issue)
nodkey preapprove --login ITEM --url URL, thenauth loginwithin 60 s.itemRefis the item ID; a name is refused.url(agent-browser sendsnull): refused.nodkeysubcommand.Found while recording (agent-browser 0.38.1): it drops the answer of a plugin that exits non-zero, so the plugin exits 0 whenever it wrote an answer;
commandis not split at spaces, so the subcommand goes inargs; forauth loginit does not show the error text.Tests
internal/client/abplugin_test.go:TestPluginContract(pre-approval tap after 100 s on the fake clock, then the recordedcredential.resolvegets the login with no new message; second login gets "needs a tap" and no message; recordednodkey.totpgives the RFC 6238 code once; recordednodkey.list),TestPluginValuesOnlyInTheCredential(password not in stderr, other answers, or the audit log),TestPluginRefusals(20 deny cases),TestPluginBrokerRefusals,TestPluginDeadline,TestPluginPageWithFragment,TestPluginManifestAndUsage,TestCredentialAnswer(JSON escaping, exact buffer, non-UTF-8 refused).internal/broker/logins_test.go:TestLoginNoTap,TestLoginNoTapReprompt,TestLoginNoTapHeaderValues.internal/approval/login_test.go:TestLoginNoTap(NoTap on secrets or a pre-approval is not allowed).go test -race ./...,go vet ./...,golangci-lint run --build-tags e2e: pass.Security review
The
security-revieweragent found no critical, high or medium problems. It found 4 low ones and 1 note: the help text showed a config that does not work, the TOTP 403 text was wrong for some causes, the docs said "fixed text" too strongly, some deny tests were missing, and the plugin returned the raw page instead of the broker's form of it. All are fixed in this PR, and the reviewer checked the fixes.Progress
🤖 Generated with Claude Code