Skip to content

test: flaky CI: TestStandingOutsideWindowAlarmFails and unused gosec G703 nolint directives #186

Open

Description

@groupsky

On 2026-11-15, the first CI run of #185 failed in two places that the change does not touch. A rerun of the failed jobs passed with no code change.

  1. test (stable): TestStandingOutsideWindowAlarmFails in internal/broker/standinguse_test.go:458 said "1 alarms went out". It passed 5 times in a row locally with -race -count=5.
  2. lint: nolintlint said the //nolint:gosec // G703 directives in internal/store/home.go (lines 63, 72, 76) and internal/store/helpers_test.go:37 are unused. The same golangci-lint v2.14.0 finds them used locally and on the rerun. So gosec's G703 result seems to change from run to run.

Run: https://github.com/code6x/nodkey/actions/runs/43744833657 (attempt 1).

Done when

  • The cause of the flaky alarm count in TestStandingOutsideWindowAlarmFails is found and fixed, and the test passes with -race -count=50.
  • The lint step no longer fails at random on the G703 directives (for example, the directives are written so that nolintlint accepts them whether or not gosec reports G703).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions