Require Biome project opt-in for built-in LSP - #11
Open
cosmosjeon wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
biome.json,biome.jsonc, or apackage.jsondependency on@biomejs/biomeas opt-in.Validation
npx vitest --run test/server-resolution.test.tsnpm testnpm run check/tmp/.../style.cssreturnedNo LSP server configured for extension: .css, with no@biomejs/biomeorbiome lspprocess before/after.biome.jsonfixture returnedNo diagnostics found, and no Biome process remained after cleanup.Notes
Summary by cubic
Require explicit Biome project opt-in for the built-in LSP when resolving by file or directory paths. Prevents starting Biome in unrelated workspaces; pathless resolution and explicit project/user LSP config remain unchanged.
biome.json,biome.jsonc, or@biomejs/biomeinpackage.json(any dependency field).biome.json/biome.jsonc, and@biomejs/biomedependency cases.Written for commit f3b0dc7. Summary will update on new commits.