Reapply Mailchimp list member sync fixes#19
Open
matt-riemer wants to merge 3 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
set_list_member is a PUT upsert: status updates an existing contact while status_if_new is required to create a new one. The payload only sent status, so genuinely new subscribers failed validation. Mirror the desired status into status_if_new so new and existing members are both handled. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The categories and interests calls omitted count, so Mailchimp's default page size of 10 applied and silently truncated the results. Lists with more than 10 interest categories, or a category with more than 10 groups, would drop the overflow and make those interests unsubscribable. Pass count: 1000 (the endpoint maximum) like the other index calls. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies the Mailchimp API fixes from #17, which were reverted in #18. The changes are byte-identical to the original PR.
Changes
set_list_member(d6df789)status_if_newwhen adding a Mailchimp list member (da6c4bd)00e7eb6)Touches
app/models/effective/mailchimp_api.rband addstest/models/mailchimp_api_test.rb.🤖 Generated with Claude Code