This repository was archived by the owner on Mar 20, 2024. It is now read-only.
BUGFIX: Dont stop loop on empty array#174
Open
whmyr wants to merge 2 commits intocodappix:developfrom
Open
Conversation
If the fetched record batch gets emptied because of the rootline filter the loop gets interrupted and lasting records may get skipped from further processing
DanielSiepmann
approved these changes
Jun 5, 2019
Contributor
|
We probably should add tests covering this situation. |
Contributor
|
Please rebase with latest |
Author
Done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the fetched record batch gets emptied because of the rootline filter
the loop gets interrupted and lasting records may get skipped from
further processing