Fix error in formula for deletion computation#7
Open
louismartin wants to merge 1 commit intococoxu:masterfrom
Open
Fix error in formula for deletion computation#7louismartin wants to merge 1 commit intococoxu:masterfrom
louismartin wants to merge 1 commit intococoxu:masterfrom
Conversation
In order to compute the correct deletions "delgramcountergood_rep" we need to take the intersection between deletions in predictions and deletions in references, however the code computed the difference between the deletions in predictions and the counts in references (not even the deletions in references).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to compute the correct deletions "delgramcountergood_rep" we
need to take the intersection between deletions in predictions and
deletions in references, however the code computed the difference
between the deletions in predictions and the counts in references (not the deletions in references).