test: middleware unit tests for rateLimiter and validateZod (closes #85) - #153
Merged
oraimoitel merged 1 commit intoAug 2, 2026
Conversation
Unit test coverage for middleware/rateLimiter.js and middleware/validateZod.js was added in 813a4d2 (tests/rateLimiter.test.js, tests/rateLimiterFailClosed.test.js, tests/validateZod.test.js) but that commit didn't reference this issue, so it never auto-closed. This commit links the existing work to the issue. - Rate limiter edge cases covered: fail-closed on Redis outage, threshold boundary (100 vs 101), TTL set only on first request, x-forwarded-for fallback, unknown_ip fallback, Redis error handling. - Zod validation covered: success path, body/query/params failure with field-level error details, fastify plugin decoration. - npm test passes (31/31). Closes cocor-tech#85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Links already-merged middleware test coverage to issue #85, which never auto-closed because the commit that added it (813a4d2) didn't reference the issue number.
tests/rateLimiter.test.js— rate limiter edge cases: fail-closed on Redis outage, threshold boundary (100 vs 101), TTL set only on first request,x-forwarded-forfallback,unknown_ipfallback, Redis error handlingtests/rateLimiterFailClosed.test.js— dedicated fail-closed regression testtests/validateZod.test.js— Zod validation success path, body/query/params failure with field-level error details, fastify plugin decorationThis PR itself carries no code changes (empty commit) — it exists solely to close #85 via the commit trailer, since that work already shipped to master.
Test plan
npm testpasses (31/31) on master with this historyCloses #85