feat: build Windows desktop app in Node 24 CI - #32
Merged
Conversation
coconilu
marked this pull request as ready for review
July 26, 2026 11:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
desktop-buildworkflow using Node.js 24, Python 3.12, Rust, Tauri, and NSISGet-FileHashcmdletWhy
The desktop source was buildable locally but had no GitHub workflow that produced a downloadable Windows installer. A real local build also exposed an exception-order bug:
UnicodeDecodeErrorinherits fromValueError, so extensionless Cargo metadata was incorrectly reported asSCAN_PATH_ESCAPED.The first GitHub run reached PyInstaller successfully but showed that its Windows PowerShell environment did not expose
Get-FileHash. The follow-up commit replaces that cmdlet dependency withSystem.Security.Cryptography.SHA256.ComputeHash, verified under Windows PowerShell 5.1 and PowerShell 7.Impact and boundaries
contents: read.opcstate remain outside GitValidation
/api/app-contextreturning HTTP 200 on random loopbackactionlintpassedRisk and rollback
The primary risk is Windows runner/toolchain drift or an unsigned installer triggering SmartScreen. Rollback is removal of
.github/workflows/desktop-build.ymland the associated documentation/test changes; no user data or global Agent configuration is modified.Final remote delivery evidence
8726bf5676463719f02920c94c88e6f9f22d7f9esuccess, 4m08s)actions/upload-artifact@v7; the earlier Node 20 compatibility warning is goneopc-app-windows-x64-unsigned-136be021783953a5bb74f7d1457e9506d4d36905, retained for 14 daysOPC App_0.1.1_x64-setup.exe, 10,944,534 bytes0d07e957072d600dc6576df7463a40fb5021758484f4e2a53aea3913ec1ef88e