jobs: refactor JobUpdater started function to not clobber job progress#164165
Draft
andrew-r-thomas wants to merge 1 commit intocockroachdb:masterfrom
Draft
jobs: refactor JobUpdater started function to not clobber job progress#164165andrew-r-thomas wants to merge 1 commit intocockroachdb:masterfrom
JobUpdater started function to not clobber job progress#164165andrew-r-thomas wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Contributor
|
Merging to
|
Member
|
This change is |
andrew-r-thomas
force-pushed
the
fix-job-trace-id-progress-bug
branch
2 times, most recently
from
1030cd3 to
1e3f4cd
Compare
Previously, jobs using `ProgressStorage` for progress updates would briefly drop down to 0 `fraction_completed` on resume, as the `JobUpdater` `started` function would clobber the job's progress in order to set the trace id. This patch refactors trace id updates to use message storage instead, and leave progress untouched. Fixes: cockroachdb#164160 Release note: None
andrew-r-thomas
force-pushed
the
fix-job-trace-id-progress-bug
branch
from
1e3f4cd to
dc6ac83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, jobs using
ProgressStoragefor progress updates would briefly drop down to 0fraction_completedon resume, as theJobUpdaterstartedfunction would clobber the job's progress in order to set the trace id. This patch refactors trace id updates to use message storage instead, and leave progress untouched.Fixes: #164160
Release note: None