apd: prevent NewFromString parsing invalid decimals#147
Closed
mw5h wants to merge 1 commit intocockroachdb:masterfrom
Closed
apd: prevent NewFromString parsing invalid decimals#147mw5h wants to merge 1 commit intocockroachdb:masterfrom
mw5h wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Reject non-digit characters in the mantissa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of @jms-bc's fix from #145, rebased onto current master so CI runs with the updated workflow from #146.
Summary
Fixes a parsing bug (#144) where sign characters (
+,-) immediately after a decimal point bypasssetString's sign validation and are passed tobig.Int.SetString, which accepts them. This produces corruptDecimalvalues.The fix validates that the mantissa contains only ASCII digits (0-9) after the decimal point and exponent have been removed, before it is passed to
big.Int.SetString.Original author: @jms-bc
Original PR: #145
Related issues: #144, #120