feat: surface local_socket_addrs through HcP2p trait#2
Draft
HexaField wants to merge 1 commit into
Draft
Conversation
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surfaces
local_socket_addrs()through theHcP2ptrait, enabling the AD4M executor to access transport socket addresses for WebRTC ICE candidate extraction.Changes
crates/holochain_p2p/src/spawn/actor.rs: Implementslocal_socket_addrs()— currently returns empty vec with a TODO. This is intentional: the actual implementation requires kitsune2 to be updated with thelocal_socket_addrstrait method (see holochain/kitsune2#478). Once kitsune2 releases with that change and this repo bumps its dep, the implementation here becomes a one-line delegation to the transport.crates/holochain_p2p/src/types/actor.rs: Addslocal_socket_addrs()to theHcP2ptrait definition.Why the empty implementation?
The dependency chain is: kitsune2 (transport trait) → holochain (HcP2p trait) → ad4m (GraphQL API). Each layer needs the trait surface to exist so downstream consumers can compile and wire up their code. The actual address data flows once kitsune2 is released and the dep is bumped. This is the same pattern used for other trait methods that were added before their backing implementation was ready.
Part of: coasys/ad4m#719