Add dynamic shortlinks config with moban by yukiisbored · Pull Request #94 · coala/devops

yukiisbored · 2017-12-18T16:53:55Z

Closes #4

gitmate-bot · 2017-12-18T16:54:10Z

devops.yml

+    url: "https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+user%\
+          3Acoala+label%3Adifficulty%2Fmedium+no%3Aassignee"
+  - name: review
+    url: "https://github.com/pulls?q=is%3Aopen+user%3Acoala+label%3A%22process%2\


line too long (81 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: all.yaml.

instead of a long link url, break it into parts like label: process/pending-review sort: created-asc

The problem then arises that there are many renders of the data, and they all need to do the same url conversion. So we need to have a shortlink-url.jinja2 template in coala-mobans which only renders the data into a url , and it is included in any higher level renderer. Not sure if this is supported by moban yet, but ... muck around a bit, ... and if it doesnt work ... I am very confident that the creator will add the feature once we've clearly defined it.

gitmate-bot · 2017-12-18T16:54:11Z

devops.yml

+  - name: greview
+    url: https://gitlab.com/groups/coala/merge_requests
+  - name: approved
+    url: "https://github.com/pulls?q=is%3Aopen+user%3Acoala+label%3A%22process%2\


line too long (81 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: all.yaml.

jayvdb · 2017-12-18T17:03:33Z

.moban.yml

@@ -0,0 +1,7 @@
+configuration:
+  template_dir:
+    - templates


The recommended approach now is to put templates into a .moban.dt . That is why my PRs do. We need to choose the same approach , for consistency sake. c.f. https://github.com/coala/coala/pull/4897/files#diff-ce88a447f57dae1c1ad94204c8eb7dc5R40

jayvdb · 2017-12-18T17:04:20Z

.moban.yml

+    - templates
+  configuration: devops.yml
+targets:
+  - "nginx/nginx.conf.d/coala.io.conf": "coala.io.conf"


rename the templates foo.jinja2 , and add the bear to that filespec .

jayvdb · 2017-12-18T17:06:57Z

devops.yml

@@ -0,0 +1,125 @@
+shortlinks:


This file should go into coala-mobans , as shortlinks.yml

Then in .moban.yml , add configuration-dir: ../coala-mobans/ like the others.

An immediate use of it in another repo is validating links in the docs .

It seems coala/coala-mobans still doesn't exist and currently resides under your namespace.

I am still waiting for reviews. Once it is approved, I will move it and update my PRs and then they can be merged.

jayvdb · 2017-12-18T17:10:43Z

devops.yml

+    url: "https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+user%\
+          3Acoala+label%3Adifficulty%2Fmedium+no%3Aassignee"
+  - name: review
+    url: "https://github.com/pulls?q=is%3Aopen+user%3Acoala+label%3A%22process%2\


instead of a long link url, break it into parts like label: process/pending-review sort: created-asc

The problem then arises that there are many renders of the data, and they all need to do the same url conversion. So we need to have a shortlink-url.jinja2 template in coala-mobans which only renders the data into a url , and it is included in any higher level renderer. Not sure if this is supported by moban yet, but ... muck around a bit, ... and if it doesnt work ... I am very confident that the creator will add the feature once we've clearly defined it.

jayvdb · 2017-12-18T17:11:04Z

devops.yml

+  - name: commit
+    url: https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html
+  - name: cep
+    url: https://github.com/coala/cEPs/blob/master/cEP-0000.md


host, repo, branch, filename ?

jayvdb · 2017-12-18T17:12:57Z

devops.yml

+  - name: channels
+    url: https://github.com/coala/coala/wiki/Communication-Channels
+  - name: newform
+    url: "https://docs.google.com/forms/d/e/1FAIpQLSd7g_MU_c-BMQ62WHeznrvcoXwqW\


gform: d/e/1FAIpQLSd7g_MU_c-BMQ62WHeznrvcoXwqW87O_Wq4Gz7-pp8PJ38Wdg

jayvdb · 2017-12-18T17:13:43Z

devops.yml

+    url: https://coala.io/#/gitmate
+  - name: csoc
+    url: "https://docs.google.com/forms/d/e/1FAIpQLSeR8WKkZA1R0gBDjJqfeI96jgHe9\
+          mt8zmAVm1YtB5FpJFD9gQ/viewform?usp=sf_link"


usp: sf_link

jayvdb · 2017-12-18T17:13:57Z

devops.yml

+    url: "https://docs.google.com/presentation/d/1qJpXMgA8_WJNO3eUV_ueNiU8w_1fT\
+          ethNvEuU2XHnWs/edit?usp=sharing"
+  - name: feedback
+    url: https://goo.gl/DcTPbn


jayvdb · 2017-12-18T17:15:17Z

nginx/nginx.conf.d/coala.io.conf

+        root /usr/share/nginx/html;
    }
+
+    location /newcomer { return 301 https://api.coala.io/en/latest/Developers/Newcomers_Guide.html; }


improve the template so that it adds whitespace to the tab { so that your diff doesnt have any changes. (or at least very few changes)

gitmate-bot · 2017-12-20T08:30:28Z

devops.yml

+    github_issues: "is:open is:issue user:coala label:difficulty/newcomer\
+                    -label:initiatives/gci no:assignee"
+  - name: low
+    github_issues: "is:open is:issue user:coala label:difficulty/low no:assignee"


line too long (81 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: all.yaml.

gitmate-bot · 2017-12-20T08:30:29Z

devops.yml

+  - name: low
+    github_issues: "is:open is:issue user:coala label:difficulty/low no:assignee"
+  - name: medium
+    github_issues: "is:open is:issue user:coala label:difficulty/medium no:assignee"


line too long (84 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: all.yaml.

gitmate-bot · 2017-12-20T08:30:29Z

devops.yml

+  - name: medium
+    github_issues: "is:open is:issue user:coala label:difficulty/medium no:assignee"
+  - name: review
+    github_pulls: "is:open user:coala label:process/pending review sort:created-asc"


line too long (84 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: all.yaml.

gitmate-bot · 2017-12-20T08:33:34Z

.moban.dt/coala.io.conf.jj2

+
+    {% for sl in shortlinks %}
+    location /{{ "%-10s" % sl.name }} { return 301 https://{{ get_url(sl) }}; }
+    {% endfor %}


Unlabeled control end tag

Origin: Jinja2Bear, Section: all.jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp6jl5e9j8/.moban.dt/coala.io.conf.jj2 +++ b/tmp/tmp6jl5e9j8/.moban.dt/coala.io.conf.jj2 @@ -17,5 +17,5 @@ {% for sl in shortlinks %} location /{{ "%-10s" % sl.name }} { return 301 https://{{ get_url(sl) }}; } - {% endfor %} + {% endfor %}{# for sl in shortlinks #} }

gitmate-bot · 2017-12-20T08:33:34Z

.moban.dt/links.html.jj2

+                    <td><a href="https://coala.io/{{ sl.name }}">{{ sl.name }}</a></td>
+                    <td><a href="https://{{ get_url(sl) }}">{{ get_url(sl) }}</a></td>
+                </tr>
+                {% endfor %}


Unlabeled control end tag

Origin: Jinja2Bear, Section: all.jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp6jl5e9j8/.moban.dt/links.html.jj2 +++ b/tmp/tmp6jl5e9j8/.moban.dt/links.html.jj2 @@ -28,7 +28,7 @@ <td><a href="https://coala.io/{{ sl.name }}">{{ sl.name }}</a></td> <td><a href="https://{{ get_url(sl) }}">{{ get_url(sl) }}</a></td> </tr> - {% endfor %} + {% endfor %}{# for sl in shortlinks #} </ul> </div> </body>

gitmate-bot · 2017-12-20T08:33:35Z

.moban.dt/url_builder.jj2

+{%- endmacro %}
+
+{% macro gpresentation(id) -%}
+  docs.google.com/presentation/d/{{id}}/edit


Variable blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: all.jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp6jl5e9j8/.moban.dt/url_builder.jj2 +++ b/tmp/tmp6jl5e9j8/.moban.dt/url_builder.jj2 @@ -19,7 +19,7 @@ {%- endmacro %} {% macro gpresentation(id) -%} - docs.google.com/presentation/d/{{id}}/edit + docs.google.com/presentation/d/{{ id }}/edit {%- endmacro %} {% macro github_issues(q) -%}

gitmate-bot · 2017-12-20T08:33:36Z

.moban.dt/url_builder.jj2

+{%- endmacro %}
+
+{% macro get_url(sl) %}
+  {% if sl.api_doc is defined -%}


Control blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: all.jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp6jl5e9j8/.moban.dt/url_builder.jj2 +++ b/tmp/tmp6jl5e9j8/.moban.dt/url_builder.jj2 @@ -39,7 +39,7 @@ {%- endmacro %} {% macro get_url(sl) %} - {% if sl.api_doc is defined -%} + {% if sl.api_doc is defined - %} {{ api_doc(sl.api_doc) }} {%- elif sl.user_doc is defined -%} {{ user_doc(sl.user_doc) }}

gitmate-bot · 2017-12-20T08:33:37Z

.moban.dt/url_builder.jj2

+  {%- elif sl.user_doc is defined -%}
+    {{ user_doc(sl.user_doc) }}
+  {%- elif sl.cEP is defined -%}
+    {{ cEP(sl.cEP)}}


Variable blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: all.jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp6jl5e9j8/.moban.dt/url_builder.jj2 +++ b/tmp/tmp6jl5e9j8/.moban.dt/url_builder.jj2 @@ -44,7 +44,7 @@ {%- elif sl.user_doc is defined -%} {{ user_doc(sl.user_doc) }} {%- elif sl.cEP is defined -%} - {{ cEP(sl.cEP)}} + {{ cEP(sl.cEP) }} {%- elif sl.gform is defined -%} {{ gform(sl.gform) }} {%- elif sl.gpresentation is defined -%}

gitmate-bot · 2017-12-20T08:33:38Z

.moban.dt/url_builder.jj2

+{%- endmacro %}
+
+{% macro get_url(sl) %}
+  {% if sl.api_doc is defined -%}


Control start tag has no corresponding end

Origin: Jinja2Bear, Section: all.jinja2.

gitmate-bot · 2017-12-20T08:37:51Z

.moban.dt/url_builder.jj2

+{%- endmacro %}
+
+{% macro get_url(sl) %}
+  {% if sl.api_doc is defined -%}


Control blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: all.jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp3p7yqex9/.moban.dt/url_builder.jj2 +++ b/tmp/tmp3p7yqex9/.moban.dt/url_builder.jj2 @@ -39,7 +39,7 @@ {%- endmacro %} {% macro get_url(sl) %} - {% if sl.api_doc is defined -%} + {% if sl.api_doc is defined - %} {{ api_doc(sl.api_doc) }} {%- elif sl.user_doc is defined -%} {{ user_doc(sl.user_doc) }}

Looks like there's a bug with whatever linter we use for jinja2, this is a valid syntax since we don't want it to add the whitespaces after this block.

gitmate-bot · 2017-12-20T08:37:52Z

.moban.dt/url_builder.jj2

+{%- endmacro %}
+
+{% macro get_url(sl) %}
+  {% if sl.api_doc is defined -%}


Control start tag has no corresponding end

Origin: Jinja2Bear, Section: all.jinja2.

jayvdb · 2017-12-20T08:46:59Z

.moban.yml

+  configuration: devops.yml
+  configuration_dir: ../coala-mobans/
+targets:
+  - "nginx/nginx.conf.d/coala.io.conf": "coala.io.conf.jj2"


we need quotes because ... ? the / ?

no, i think i was looking at configs on pyexcel. let me change that.

jayvdb · 2017-12-20T08:47:27Z

devops.yml

+  - name: newcomers
+    api_doc: Developers/Newcomers_Guide
+  - name: new
+    github_issues: "is:open is:issue user:coala label:difficulty/newcomer\


github_issues: - is:open - is:issue - user:coala - label:difficulty/newcomer - "-label:initiatives/gci" - no:assignee

jayvdb · 2017-12-20T08:49:19Z

devops.yml

+  - name: viperform
+    gform: 1FAIpQLSdtdIF5CLnO2erAc41yLRoEvUMXyt3ZWUOVJ5LSqpwZEYF03A
+  - name: romania
+    url: "www.bigmarker.com/remote-meetup/Open-Source-and-Google-Summer-of-Code\


no protocol?

it's on the nginx template.

jayvdb · 2017-12-20T08:53:04Z

nginx/nginx.conf.d/coala.io.conf

    }

-    # URL shortener
-    location /newcomer  { return 302 http://api.coala.io/en/latest/Developers/Newcomers_Guide.html; }


nginx doesnt support redirects without a protocol?

if not, can you add a PR first to replace http->https or https->http , so then this diff has only minimal changes.

it's not that nginx doesn't support it. It just throws HTTP 302 with whatever after it. Some programs get confused when there's no protocol.

I think I'll just make some changes to the coala.io.conf so this diff will be lower.

This hasnt been done , it appears

Closes #4

jayvdb · 2018-04-18T19:51:08Z

update mobans repo and rebase...

yukiisbored added the process/wip label Dec 18, 2017

yukiisbored self-assigned this Dec 18, 2017

gitmate-bot added process/pending review size/L difficulty/low importance/low status/stale type/feature type/new service labels Dec 18, 2017

gitmate-bot reviewed Dec 18, 2017

View reviewed changes

jayvdb reviewed Dec 18, 2017

View reviewed changes

jayvdb requested changes Dec 18, 2017

View reviewed changes

yukiisbored force-pushed the yuki_is_bored/shortlinks branch from 4787c74 to d047087 Compare December 20, 2017 08:30

gitmate-bot reviewed Dec 20, 2017

View reviewed changes

yukiisbored force-pushed the yuki_is_bored/shortlinks branch 2 times, most recently from f6f9bd8 to c69cb97 Compare December 20, 2017 08:33

gitmate-bot reviewed Dec 20, 2017

View reviewed changes

yukiisbored force-pushed the yuki_is_bored/shortlinks branch from c69cb97 to 9e3bb69 Compare December 20, 2017 08:37

gitmate-bot reviewed Dec 20, 2017

View reviewed changes

yukiisbored force-pushed the yuki_is_bored/shortlinks branch from 9e3bb69 to c62c862 Compare December 20, 2017 08:42

yukiisbored removed the process/pending review label Dec 20, 2017

gitmate-bot added the process/pending review label Dec 20, 2017

yukiisbored force-pushed the yuki_is_bored/shortlinks branch from 2a0d451 to e6d9f2f Compare December 20, 2017 08:45

yukiisbored removed the process/pending review label Dec 20, 2017

jayvdb reviewed Dec 20, 2017

View reviewed changes

Add dynamic shortlinks config with moban

018d5fb

Closes #4

yukiisbored force-pushed the yuki_is_bored/shortlinks branch from e6d9f2f to 018d5fb Compare December 20, 2017 08:53

gitmate-bot added the process/pending review label Dec 20, 2017

jayvdb removed process/pending review process/wip labels Apr 18, 2018

Conversation

yukiisbored commented Dec 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayvdb Dec 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yukiisbored Dec 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayvdb Dec 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayvdb Dec 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayvdb Dec 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

jayvdb Dec 18, 2017 •

edited

Loading

yukiisbored Dec 20, 2017 •

edited

Loading

jayvdb Dec 18, 2017 •

edited

Loading

jayvdb Dec 18, 2017 •

edited

Loading

jayvdb Dec 20, 2017 •

edited

Loading

jayvdb commented Apr 18, 2018 •

edited

Loading