Skip to content

chore: make crates.io publishing manual - #241

Merged
smiggleworth merged 2 commits into
mainfrom
chore/manual-crates-io-publish
Aug 20, 2026
Merged

chore: make crates.io publishing manual#241
smiggleworth merged 2 commits into
mainfrom
chore/manual-crates-io-publish

Conversation

@smiggleworth

Copy link
Copy Markdown
Contributor

Summary

Make crates.io publishing manual-only and require the workflow to be dispatched from a release tag.

Why are you making this contribution?

Publishing should be an intentional release action rather than an automatic response to every tag push.

Linked issues

No issue: release workflow policy.

Acceptance audit

  • Criterion: Publishing is manual and cannot run from a non-tag ref.
    Evidence: The workflow uses only workflow_dispatch and checks GITHUB_REF_TYPE=tag before the release gate.
    Production entry point: .github/workflows/publish.yml publishes cntryl-midge through the existing release gate and OIDC job.
    Resolution: Matches the requested manual publishing approach.

Risk and compatibility

Existing release validation, required checks, and OIDC authentication remain unchanged.

Verification

  • Workflow structure reviewed.
  • git diff --check passed.

Tool assistance disclosure

  • AI or another generative tool materially assisted this contribution.
    The workflow change was reviewed and validated before submission.

Contributor responsibility

  • I understand the complete change and can explain or revise it.
  • I reviewed the complete diff.
  • I reported validation accurately and did not claim checks I did not run.
  • I disclosed material generated assistance.
  • I have the right to submit this work under the repository's license.

Review checklist

  • Behavioral tests use the real production entry point, not only private helpers.
  • New enum variants update tests/coverage_manifests.rs.
  • Coexisting implementations have a differential test, or the unused variant is removed.
  • Shared test infrastructure uses poison-tolerant locks and consistent failpoint gates.
  • Failpoint governance relies on mechanical call-site discovery, not a hardcoded allowlist.
  • Expensive coverage and mutation checks remain scheduled/manual unless their CI cost is explicitly approved; Sqrzl remains the self-contained cloud qualification authority.
  • A real-provider behavior difference is reproduced in Sqrzl and retained as a Midge regression test where applicable.
  • Every linked issue criterion is represented above; this workflow-only change has no linked issue criteria.

Copilot AI lite review requested due to automatic review settings August 20, 2026 21:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@smiggleworth
smiggleworth merged commit 0dd2b53 into main Aug 20, 2026
4 checks passed
@smiggleworth
smiggleworth deleted the chore/manual-crates-io-publish branch August 20, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants