Skip to content

fix: handle DuckDB arrow() returning multiple types in duckdb_demo#48

Merged
cning112 merged 1 commit into
mainfrom
fix/duckdb_demo
May 2, 2026
Merged

fix: handle DuckDB arrow() returning multiple types in duckdb_demo#48
cning112 merged 1 commit into
mainfrom
fix/duckdb_demo

Conversation

@cning112

@cning112 cning112 commented May 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • DuckDB's .arrow() can return RecordBatchReader, RecordBatch, or Table depending on the query
  • Previously the code assumed only RecordBatchReader, causing type errors for queries returning single batches or tables
  • Also skip empty batches to avoid downstream errors

Test plan

  • Run duckdb_demo.py with various query types (aggregations, full table scans, single row)
  • Verify no type errors from .arrow() return values

🤖 Generated with Claude Code

@cning112 cning112 merged commit 7e102e6 into main May 2, 2026
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant