More HE OB falloff when entering pylon protection#12540
Open
Drulikar wants to merge 1 commit into
Open
Conversation
Drulikar
added
the
Balance Approved
cmss13-ci
Bot
added
Balance
github-project-automation
Bot
moved this from Awaiting Review
to Partially Approved / Mergeable
in Review Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR adds two new falloff "shapes"
EXPLOSION_FALLOFF_SHAPE_EXPONENTIAL_IN_PYLON, andEXPLOSION_FALLOFF_SHAPE_EXPONENTIAL_HALF_IN_PYLONand changes standard high explosive orbital bombardments to useEXPLOSION_FALLOFF_SHAPE_EXPONENTIAL_IN_PYLON. This means that the HE OB explosion entering into the protected area loses power exponentially.Explain why it's good for the game
Cluster explosions are already small enough to not encroach too much into protected areas, and incend strictly follows the shape (though it ought to not be so square). So HE was the only OB that more or less ignored the protection allowing the core itself to even receive substantial explosion damage.
Testing Photographs and Procedure
Screenshots & Videos
Red region of protection set via
SDQL2-query "UPDATE /turf/open IN (@[/obj/effect/alien/resin/special/pylon/core MAP linked_turfs])[1] set color = "#ff0000"OLD:
NEW:
https://youtu.be/Po0KOZLwkaQ
Changelog
🆑 Drathek
balance: HE OB now has exponential falloff when entering into pylon protected areas
/:cl: