Fix tower conversion when near a core#12535
Open
Drulikar wants to merge 2 commits into
Open
Conversation
cmss13-ci
Bot
added
Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR fixes a niche issue where a cluster is unable to convert a comms tower if the weeds under the tower are controller by a core. Now when weeds are completed for a cluster or when a tower is triggered, it situationally checks if a tower should try conversion regardless of the weeds its on.
I also fixed an issue where the previously qdeleted node remains in the children of the converted pylon (though its a bit goofy that nodes are putting themselves into children).
Explain why it's good for the game
Fixes a non-intuitive aspect of a core preventing tower conversion.
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/kuWTWb5rlq4
Changelog
🆑 Drathek
fix: Fixed clusters being unable to convert towers because they're in core weeds
/:cl: