Guns can drop bullet casings x2#12491
Open
Nihisohel wants to merge 57 commits into
Open
Conversation
Co-authored-by: fira <loyauflorian@gmail.com>
Co-authored-by: fira <loyauflorian@gmail.com>
This reverts commit 213ba11.
Contributor
Author
|
humble mapping lint failure |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Explain why it's good for the game
Re-opens #9404
Ship of Theseus port of a PVEs server casings code, changes bullet casings into a cleanable decal for better performance handling, theoretically
Also includes backend to allow mappers to randomize casing types on mapload, for flavor, of course
Still needs one TM to properly check out garbage deletion and cleaning
Testing Photographs and Procedure
Changelog
🆑 Nihisohel, LCMS1 for sprites
add: Guns with the appropriate ammunition type and presentation now litter the ground with their spent cases and cartridges.
spellcheck: Tweaks some misrepresented lore about XM43E1 casings.
mapadd: Adds backend for making randomized casings on mapload, and the ability to disable such for mappers
maptweak: Changes every instance of Tyrargo's prop parent varedited into faux casings into the actual casing parent
/:cl: