Added Caching to workflows - #1502
Closed
pxsit wants to merge 2 commits into
Closed
Conversation
gollux
reviewed
Aug 6, 2025
| - push | ||
| - pull_request | ||
| push: | ||
| branches: [ main, develop ] |
Contributor
There was a problem hiding this comment.
Do we have a branch called develop?
| - name: Cache Docker layers | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: /tmp/.docker-cache |
Contributor
There was a problem hiding this comment.
Is there any particular reason for naming the directory with a dot? Just /tmp/docker-cache would seem more straightforward.
Member
|
Please explain how this is supposed to be better than #1477. Also, currently the debian test is broken; the "run tests" step rebuilds the ubuntu image and uses that instead. (note that #1477 wasn't quite negative performance impact, I just deemed it not good enough. If we decide the 45 second win is worth the added complexity it brings then we can still pursue this approach.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Docker layer caching
Instead of rebuilding the entire Docker image from scratch on every commit, the optimized workflow uses actions/cache to save and reuse the layers of your Docker image. On a new commit, Docker will only have to rebuild the layers that have actually changed, while reusing all the previous layers from the cache.