Run Github Actions on Debian - #1490
Merged
Merged
Conversation
veluca93
approved these changes
Jul 31, 2025
veluca93
left a comment
Contributor
There was a problem hiding this comment.
Please wait until EOW :-)
Member
Author
|
hmm, it shows that CI passed on both "test (debian)" and "test (ubuntu)", but it's still waiting for "test". I guess this is due to some weirdness with the branch protection rules? But I don't have permissions to look at those, so someone else will have to tinker with them... |
* Removed cgroup-lite (seems useless? and not present on debian) * changed openjdk-8-jdk-headless to default-jdk-headless (17 on debian, 21 on ubuntu) * changed python3.12 to python3 (uses 3.11 on debian) * use correct version of isolate (previously we were installing the debian package on ubuntu... why does that even work??) * added .venv (used by uv) to dockerignore as (when using uv) it's pretty big and useless inside the container
prandla
force-pushed
the
gh-actions-debian
branch
from
August 5, 2025 07:50
327b88c to
aeb4abb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One test actually broke on debian because of python 3.11, because of changes in zipfile.py in python 3.12 which I inadvertently depended on (namely the "archive with empty filename" test). I don't think either behavior is a problem though, it shouldn't really matter which way this edge case is resolved, the user will get an error message either way in the end.
And finally, run the CI with both ubuntu and debian images. We'll see if it works first try :)