Skip to content

Run Github Actions on Debian - #1490

Merged
wil93 merged 3 commits into
cms-dev:mainfrom
e-i-o:gh-actions-debian
Aug 5, 2025
Merged

Run Github Actions on Debian#1490
wil93 merged 3 commits into
cms-dev:mainfrom
e-i-o:gh-actions-debian

Conversation

@prandla

@prandla prandla commented Jul 31, 2025

Copy link
Copy Markdown
Member
  • Refactored the Dockerfile to allow building both Debian- and Ubuntu-based images from the same file.
  • Various other cleanups in the dockerfile:
    • Use cache mounts to avoid re-downloading packages when rebuilding. Note that this is not the same type of caching I tried in a previous PR, in particular this one doesn't help with CI at all, but it helps a lot locally to speed up rebuilds when tinkering with the dockerfile.
    • made the shell commands a bit cleaner using heredoc syntax.
    • use the correct isolate repository for the current distro, instead of hardcoding bookworm
    • tweaked the installed package list a bit for debian, see the commit message for details. Notably, upgrade java from version 8 to 17 or 21 (debian only packages one version of java).

One test actually broke on debian because of python 3.11, because of changes in zipfile.py in python 3.12 which I inadvertently depended on (namely the "archive with empty filename" test). I don't think either behavior is a problem though, it shouldn't really matter which way this edge case is resolved, the user will get an error message either way in the end.

And finally, run the CI with both ubuntu and debian images. We'll see if it works first try :)

@veluca93 veluca93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait until EOW :-)

@prandla

prandla commented Aug 4, 2025

Copy link
Copy Markdown
Member Author

hmm, it shows that CI passed on both "test (debian)" and "test (ubuntu)", but it's still waiting for "test". I guess this is due to some weirdness with the branch protection rules? But I don't have permissions to look at those, so someone else will have to tinker with them...

prandla added 3 commits August 5, 2025 10:50
* Removed cgroup-lite (seems useless? and not present on debian)
* changed openjdk-8-jdk-headless to default-jdk-headless (17 on debian,
  21 on ubuntu)
* changed python3.12 to python3 (uses 3.11 on debian)
* use correct version of isolate (previously we were installing the
  debian package on ubuntu... why does that even work??)
* added .venv (used by uv) to dockerignore as (when using uv) it's
  pretty big and useless inside the container
@prandla
prandla force-pushed the gh-actions-debian branch from 327b88c to aeb4abb Compare August 5, 2025 07:50
@wil93
wil93 merged commit 6dcd821 into cms-dev:main Aug 5, 2025
4 checks passed
@prandla
prandla deleted the gh-actions-debian branch August 12, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants