clean up some imports - #1472
Merged
Merged
Conversation
prandla
commented
Jul 22, 2025
prandla
commented
Member
- Remove unneeded import attempts from "tornado4". From what I can tell, this was only ever useful when using system packages on ubuntu 20.04. We don't support installation using system packages anymore (and ubuntu 20.04 is EOL).
- Remove misleading comment about monkey-patching the DB connection string in the test suite. We don't monkey-patch it anymore (instead we assume someone else fixed it and assert that it's correct).
* Remove unneeded import attempts from "tornado4". From what I can tell, this was only ever useful when using system packages on ubuntu 20.04. We don't support installation using system packages anymore (and ubuntu 20.04 is EOL). * Remove misleading comment about monkey-patching the DB connection string in the test suite. We don't monkey-patch it anymore (instead we assume someone else fixed it and assert that it's correct).
wil93
approved these changes
Jul 23, 2025
pxsit
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.