"Rerun and archive sandbox" button in AWS

[prandla]

Closes #1355.

This still needs a dump updater and SQL updater (because i changed the "sandbox paths" column from a :-separated string to an array). Other parts should be ready for review though.

I changed the UI a bit from the old implementation:

sandbox links are clickable when archived. There's also a similar button for the compile sandbox.

There's also most of the logic to archive user test sandboxes, but there's no RPC to invalidate them, so it can't actually be reached currently...

[veluca93]

The overall approach seems reasonable to me, but I'd like a second look from @gollux :-)

[prandla]

should be all done now.

[gollux]

Beware that some files in the sandbox could be unreadable for the user running CMS. Well, it should not happen in the first place, but due to #1242, it can.

[prandla]

i think it's only possible for compilation (for evaluation, allow_writing_only should prevent it i think?), but it is indeed a possibility.

i think the proper way to handle this is to implement #1242, and then implement an archiver that chmods files as it goes to make them readable. (this then requires some trickery to get the metadata in the archive right.) we would also need similar chmodding before deleting the sandbox (or just letting isolate deal with it).

for now, i guess i can add an extra check and make sure that the case where creating the archive fails is at most a warning.

[gollux]

For now, i guess i can add an extra check and make sure that the case where creating the archive fails is at most a warning.

I agree.

Otherwise, I think that allow_writing_only is a terrible hack and I am looking forward for the moment when we remove it. But we really should wait with #1242 for after the IOI :)

[prandla]

@gollux does this last patch look okay? :)

[gollux]

@gollux does this last patch look okay? :)

Yes.