Two fixes for mdns#92
Closed
mhei wants to merge 2 commits into
Closed
Conversation
The default values should be loaded into the correct variables. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Calling e.g. gensiot 'mdns(type=_iostream._tcp)' i.e. without a specific name after, should be possible and according to the documentation it should give you the first enumerated service. However, from code perspective, mstr is not NULL in this case but has zero length. So add an additional check for this, otherwise the name is set to zero-length string too which prevents later a correct comparision. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Owner
|
Merged, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two initialization typos and covers an edge-case when no service name shall be used when connecting via mdns.