Repository navigation
Companion: dresses, shoes and more clothes (#34) - #38
Merged
Merged
Conversation
Art first, in design/companero/prendas/: a flower dress, a party dress, a skirt, a headband with a flower, a big bow, a pearl necklace, and sneakers, boots and sandals on a new fourth slot, the feet (anchored at 60,160 on all eight animals). prendas.mjs checks 128 pairs in headless Chrome, 0 covering the face or leaving the frame; it caught the necklace and both dresses touching the otter's mouth, now fixed. The preview has three new outfits with shoes. In the app: the nine garments join the catalogue at their prices, the clothes section gets a fourth sliding row for the feet, and every name is in the five languages. A dress replaces the sweater or the cape (one garment per slot); shoes go with anything. An inventory from before opens with bare feet. Any garment fits any animal: the shop does not sort by gender. COMPANERO.md has the prices and the new total, 4,090. The test harness retries Chrome on a fresh port when the one it picked is still held by the Chrome before it, which made a run fail now and then with no real error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34
Art (in
design/companero/prendas/, reviewed before wiring)vestido)gala)falda)diadema)mono)perlas)zapatillas)botas)sandalias)pies, anchored at (60, 160) on all eight animals, whose feet are drawn in the same place.prendas.mjs→ «128 combinaciones, 0 superposiciones». On the way it caught the necklace and both dresses touching the otter's mouth (its face sits lower), now fixed. The white sneakers read poorly at small size, so they are blue.App
CATALOGO. The clothes section gets a fourth sliding row for the feet, and every name is in the five languages.COMPANERO.mdhas the new prices and the new total of everything permanent: 4,090 coins (about 510 games).Test harness
navegador()now retries Chrome up to three times on a fresh port. A random port could still be held by the Chrome of the group before it, so a run failed now and then with no real error. It happened twice locally while working on #33 and #34; with the retry, three runs in a row passed.Checks run locally
node tools/test-companero.js: 252 green, three runs in a row. New:node tools/test.js: 5,610 green ·./tools/browser-check.sh: 52 of 52.