Repository navigation
Companion: a fixed stage, care first and sliding rows (#31) - #35
Merged
Merged
Conversation
Tried on a phone, the whole page scrolled as one: to reach Care the companion had already left the screen, so a care showed no reaction. - The stage (the companion, its wish and its bond) sticks right under the game bar, which already keeps the coins in view; the options scroll under it. - Sections go Care, Animals, Colours, Clothes, each one row that slides sideways card by card (finger, keyboard, or a mouse wheel while the row can still move); the three clothes rows stay apart. - The wish floats over the card and hides after 4 s; tapping the companion (or Enter) shows it again, and so does fulfilling it. Hiding it changes nothing about the wish. - Smaller companion on short screens; no transition under reduced motion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
Tried on a phone, the whole page scrolled as one. To reach Care, the companion had already left the screen, so a care showed no reaction. Layout only: no new feature, no new art.
Changes
Checks run locally
node tools/test-companero.js: 213 green. New, in a real browser at 390 × 740:node tools/test.js: 5,610 green ·./tools/browser-check.sh: 52 of 52.