Repository navigation
Companion: final integration and its economy documented (#10) - #30
Merged
Merged
Conversation
No new features. The final gate shows the pieces work together, keep existing data and leave the offline app as it was: - An old profile keeps its coins, unlocks, palette, character, stats and name after opening and caring for the companion; a character bought in the core stays the companion's own. - A new profile goes through the welcome, wears a rabbit, a design and a cap, and feeds a fruit; the balance drops exactly what was spent. - Broken JSON, unknown ids, partial data and a future version open the page with defaults and the balance untouched, with no console error. - «Erase everything» in the profile removes every chogan.companero.* key, through the real button and its red confirmation. - No companion file asks the network for anything, each module is in the entry's files for the service worker, and the APK still asks only to vibrate. - Every string in the five languages, Persian right to left, nothing wider than 390 px, and every button named for a screen reader. COMPANERO.md documents the rule (wishes, never needs), the sources and sinks of coins, the price of every item (checked against CATALOGO by a test), the total of 2,770 coins, the data and the decisions. One visual fix: a long name broke out of its card in German; it now breaks at its soft hyphen (Wasser-schwein).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
The last piece of the companion (#2). No new features: the gate shows that the pieces work together, keep existing data and leave the offline app as it was.
What the new checks prove (all in
tools/test-companero.js, in a real browser)chogan.companero.*key.fetch,XMLHttpRequest,WebSocket,sendBeaconor a remote URL;files, so the service worker keeps it offline;Documentation
COMPANERO.md(Spanish, for the team) documents:C.stats.record;CATALOGO;It is a file of our own, not
DECISIONS.md, which belongs to upstream.One visual fix
In German, «Wasserschwein» broke out of its card. It now breaks at a soft hyphen («Wasser-schwein»), and any long name without one wraps inside its card.
Checks run locally
node tools/test-companero.js: 197 green (46 new).node tools/test.js: 5,610 green../tools/browser-check.sh: 52 of 52.upstream/main: done in Sincronizar con el original 0.20.0 #28/Sync with upstream 0.20.0 (#28) #29. The fork is now level with upstream 0.20.0, so there is nothing left to conflict.Outside this PR
wccr_sitio) leaves the companion out of its game count, in its own PR there.v0.20.0-capybara.1) comes after this merges.