Repository navigation
Companion: the eight animals, and buying the new ones (#6) - #24
Merged
Merged
Conversation
The animals region shows all eight, the capybara first. The capybara is free for everyone. The rabbit, panda and otter show their price and are bought with the core's own confirmation (as in Capybara's shop); without enough coins a toast says how many are missing. The core's owl, cat and bear, if not owned, show «unlocked in your profile» and are never sold here: the companion does not write the core's unlocks (#3). Animals not owned are drawn paler. tools/test-companero.js drives the purchase in a real browser: the price, the confirmation, the single charge, the animal worn, the reload, the toast with what is missing, the core's characters left alone and the capybara for free. The page never adds coins or awards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
What is here
In the animals region of
www/games/companero/index.html:Nothing in the core changes; showing the new animals in the profile and menu stays out of scope (epic #2).
Checks run locally
node tools/test-companero.js: 73 green. New, in a real browser: the rabbit's price, the owl locked with its note, the confirmation, the single charge (200 → 20), the rabbit worn, both persisting after a reload, the panda's toast with the 240 missing and no charge, the owl not buyable here with the core's unlocks untouched, and the capybara for free. The page source never callscoins.addorachievements.unlock.node tools/test.js: 5,482 green ·./tools/browser-check.sh: 50 of 50.