Merged
Conversation
SimonFrings
reviewed
Jan 30, 2024
README.md
Outdated
|
|
||
| ```bash | ||
| $ php vendor/bin/phpunit | ||
| php vendor/bin/phpunit |
Contributor
There was a problem hiding this comment.
I think we use this version in other projects, should be apply the same here?
Suggested change
| php vendor/bin/phpunit | |
| vendor/bin/phpunit |
Contributor
Author
There was a problem hiding this comment.
thank you for noticing this, should be fixed now.
yadaiio
force-pushed
the
Improve_documentation_and_examples
branch
2 times, most recently
from
98949b0 to
47b17b1
Compare
SimonFrings
suggested changes
Feb 2, 2024
Contributor
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Looks good so far, just noticed that examples/php.php could also need rejection handling, similar as you already did this in examples/bash.php & examples/docker.php
yadaiio
force-pushed
the
Improve_documentation_and_examples
branch
from
47b17b1 to
e4dd429
Compare
Contributor
Author
|
oops, didn't saw the |
SimonFrings
approved these changes
Feb 6, 2024
Contributor
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Thanks for applying the requested changes, looks good to me 👍
This was referenced Mar 19, 2024
This was referenced Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request builds on top of: clue/reactphp-sqlite#43 and clue/reactphp-tar#20.