Improve type definitions and update to PHPStan level max#201
Merged
SimonFrings merged 4 commits intoclue:mainfrom Oct 27, 2022
Merged
Improve type definitions and update to PHPStan level max#201SimonFrings merged 4 commits intoclue:mainfrom
max#201SimonFrings merged 4 commits intoclue:mainfrom
Conversation
SimonFrings
approved these changes
Oct 27, 2022
This was referenced Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves any type definitions and updates the test environment to PHPStan level
max. This builds on top of the initial PHPStan support added in #200 and now runs the maximum level supported without having to resort to a baseline. The changeset size seems reasonable and the PHPStan configuration ignores only a smaller number of errors for legacy PHP versions.Builds on top of #200 and #199