Skip to content

chore(checks): graduate twelve checks to block and correct stale records - #60

Merged
chrispezza merged 1 commit into
mainfrom
chore/graduate-checks-fix-records
Oct 12, 2026
Merged

chrispezza merged 1 commit into
mainfrom
chore/graduate-checks-fix-records

Conversation

@chrispezza

Copy link
Copy Markdown
Collaborator

Summary

  • Graduation. ADR 0012's rule (7+ consecutive clean days) had been met since late July and was never executed. Twelve structural checks move from warn to block, so their findings now fail CI and bounce the Stop-gate with a message that names the ADR.
  • Held at warn: manifest (reports a finding when the CLI is absent, which would stop local sessions), word-limit (ratcheted limits, most likely to trip on routine edits), self-containment (path pattern can match prose). Reasons are recorded in the ADR 0012 amendment.
  • Stale records. Appended amendments to ADRs 0003, 0004, 0008 and 0013 so each amended ADR names what amended it. ADR 0004 now records the census the check has enforced since July: 6 commands, 5 skills, 2 subagents.
  • Stale docs. Templates, README, scripts README and CONTRIBUTING no longer reference the deleted MCP server or script paths that moved into plugin/scripts/.
  • Removed docs/skills/: eight specs for the superseded eight-skill design, referenced by nothing.

Behaviour change

A finding from any of the twelve graduated checks now fails the enforcement CI job and blocks a Claude Code session from finishing its turn until fixed. Demotion is one config line plus a log entry.

Cost

No CI change. The suite still runs in well under a second.

Test plan

  • python checks/run_checks.py --ci — 15 checks, 0 findings, exit 0
  • python -m unittest discover -s checks/tests — pass
  • Every ADR change is a pure append (0 removed lines under docs/adrs/), written through the guard
  • CI green

ADR impact

  • Existing ADRs amended by appended, dated sections: 0001–0010, 0012, 0013, 0014

🤖 Generated with Claude Code

ADR 0012's graduation rule (7+ consecutive clean days) had been met since
late July and never executed, so no finding could fail CI or reach an agent
through the Stop-gate.

- Flip twelve structural checks warn -> block; keep manifest, word-limit and
  self-containment at warn with reasons recorded in ADR 0012
- Append dated graduation log entries to each owning ADR
- Append amendments to ADRs 0003, 0004, 0008 and 0013 recording what later
  ADRs changed (census of 6 commands, 5 skills, 2 subagents; registry
  extensions; reverse-pass checks that had already landed)
- Remove references to the deleted MCP server and pre-ADR 0011 script paths
  from the PR and bug templates, README, scripts README and CONTRIBUTING
- Remove docs/skills/, eight specs for the superseded eight-skill design

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chrispezza
chrispezza merged commit 298297f into main Oct 12, 2026
2 checks passed
@chrispezza
chrispezza deleted the chore/graduate-checks-fix-records branch October 12, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant