Repository navigation
fix(audit): emit audit.finding_count so Ops stops flagging plugin_skill entities - #23
Merged
Merged
Conversation
…ll entities Ops expects audit.finding_count on every plugin_skill entity but the publisher only emitted skill_audit.*, which Ops does not know, so the metric was reported missing after every publish. Emit it at severity 0 (audit.* is advisory; skill_audit.findings still carries the rank). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Ops dashboard finding:
audit.finding_countnever reported. Ops (src/config.tsEXPECTED_METRICS) expectsaudit.finding_counton everyplugin_skillentity;scripts/publish_skill_audit.pyonly emittedskill_audit.*, which Ops has no knowledge of.What
audit.finding_countsignal per entity (valueNum= linked findings, severity 0 sinceaudit.*is advisory andskill_audit.findingscarries the rank).docs/SKILL_AUDITS.mdsignal table updated (five → six).Not done here
The metric only arrives after the next publish. That needs the 1Password prompt approved, so it is left to the maintainer:
op run --env-file <env-with-OPS_INGEST_TOKEN-ref> -- python3 scripts/publish_skill_audit.py docs/audits/2026-09-05-post-fix/audit.json --publish(withOPS_URLset).Checks
validate_plugins.pyOK;unittest discover9/9; no hook files touched (shellcheck not installed locally, CI runs it).🤖 Generated with Claude Code