Skip to content

enclave: attest floor-rejected bid prices - #46

Open
josephmilla wants to merge 4 commits into
mainfrom
attest-floor-rejected-bid-prices
Open

enclave: attest floor-rejected bid prices#46
josephmilla wants to merge 4 commits into
mainfrom
attest-floor-rejected-bid-prices

Conversation

@josephmilla

Copy link
Copy Markdown
Contributor

Context

  • Encrypted floor-rejected bids previously lost their trusted prices before downstream analytics could record them.
  • The signed attestation now carries only each rejected bid ID and adjusted price, while retaining legacy response IDs.
  • Duplicate bid IDs and payloads beyond four rejected bids or 1024 encoded bytes fail closed before attestation.
  • Deploy this producer change before enabling the matching consumer that reads floor_rejected_bids from attestation user data.

Testing

  • mise run test: covers adjusted encrypted prices, legacy IDs, duplicate rejection, and attestation limits.
  • mise run lint: reports no issues across the changed core, enclave, and API packages.
  • git diff --check origin/main...HEAD: no whitespace errors in the committed diff.
  • Enclave deployment: required before consumers can observe nonzero encrypted rejection prices.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the enclave attestation user data to include trusted, post-adjustment prices for bids rejected by floor enforcement, so downstream analytics can recover these values even when bids were encrypted.

Changes:

  • Add floor_rejected_bids to attestation user data (ID + adjusted price only).
  • Plumb adjusted floor-rejected bids from core auction results through enclave proof generation into the attestation, with pre-attestation hard limits (max 4 bids; max 1024 encoded bytes).
  • Fail early on duplicate bid IDs in enclave auction processing, and add/extend tests covering the new attestation behavior and limit enforcement.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
enclaveapi/types.go Introduces AttestedFloorRejectedBid and adds floor_rejected_bids to attestation user data.
enclaveapi/types_test.go Adds JSON marshaling tests ensuring floor_rejected_bids is omitted when empty and includes only ID/price fields.
enclave/proofs.go Threads floor-rejected bids into attestation, with size/count limits checked before calling NSM attestation.
enclave/proofs_test.go Adds tests verifying limit failures happen before calling Attest, and updates call sites for new signatures.
enclave/auction.go Rejects duplicate bid IDs up front; passes core floor-rejected bids into proof generation.
enclave/auction_test.go Adds tests for duplicate ID rejection and for attesting adjusted decrypted floor-rejected prices without leaking other bid fields.
core/types.go Extends AuctionResult to include full post-adjustment FloorRejectedBids alongside IDs.
core/floorenforcement.go Refactors floor enforcement to expose rejected bids internally via partitionBidsByFloor.
core/auction.go Uses floor partitioning to return both FloorRejectedBidIDs and FloorRejectedBids in the result.
core/auction_test.go Adds coverage ensuring floor-rejected bids reflect adjusted values and that inputs aren’t mutated.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants