Eliminate bid adjustment factors - #44
Open
lukasschwab wants to merge 2 commits into
Open
Conversation
Old config field `experimental_monorepo_root` is deprecated in current versions of mise, which yields warning noise: ``` mise WARN deprecated [config.experimental_monorepo_root]: `experimental_monorepo_root` in .../openauction/.mise/config.toml is deprecated. Use `monorepo_root` instead. This will be removed in mise 2027.12.0. ```
This system was effectively unused: all auction requests from the CloudX auction-server bear vacuous (i.e. empty, 1x) bid adjustment factors. There are no immediate plans to use non-vaucous adjustmnets factors, so we removed the logic involved from the auction-server entirely. This removes the corresponding dead logic from openauction.
nickpell
approved these changes
Jul 24, 2026
nickpell
left a comment
nickpell
left a comment
Member
There was a problem hiding this comment.
Looks solid. Since this changes the attestation we'll want to run it by demand partners before shipping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This system was effectively unused: all auction requests from the CloudX auction-server bear vacuous (i.e. empty, 1x) bid adjustment factors. There are no immediate plans to use non-vaucous adjustmnets factors, so we removed the logic involved from the auction-server entirely.
This removes the corresponding dead logic from openauction.