feat(schema): expose stream writer close signal#1133
Open
Zhang-986 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
More detailed description
This exposes the existing receiver-close notification on
StreamWriter.Problem:
A stream producer can currently observe reader closure only when
Sendreturnsclosed=true. If the producer is blocked outsideSend(for example reading a stalled SSE/network stream), it cannot observe that the consumer has calledStreamReader.Close(), so the producer goroutine and upstream connection may remain alive until an external context cancels.Root cause:
The stream already has an internal
closedchannel closed bycloseRecv, butStreamWriterdoes not expose it.Change:
Add
StreamWriter.Closed() <-chan struct{}so producers can select on receiver closure and cancel blocked upstream work.Scope:
This only exposes the existing close signal. It does not change
Send,Close, buffering, copy, merge, or automatic-close behavior.Which issue(s) this PR fixes:
Fixes #1068
Test
go test ./schema -run TestStreamWriterClosedClosesWhenReaderCloses -count=1go test ./schemago test ./... -count=1git diff --check