feat(adk): add read tool hint to truncation notice#1118
Merged
N3kox merged 1 commit intoJul 8, 2026
Conversation
|
这个 PR 能合并吗 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
+ Coverage 83.28% 83.34% +0.06%
==========================================
Files 162 162
Lines 23397 23398 +1
==========================================
+ Hits 19486 19501 +15
+ Misses 2642 2629 -13
+ Partials 1269 1268 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@Zhang-986 |
cb2bb82 to
94d5bb2
Compare
Contributor
Author
|
Fixed in 94d5bb2. Applied the read tool hint to the streaming offload-saved prompts introduced by #1090, covering both default streamable and enhanced streamable truncation paths. I kept the hint on the offload-saved notice so it is only shown when the full output was actually saved. Verified:
|
N3kox
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadFileToolNameinto the default truncation handlerFixes #1110.
Tests
go test ./adk/middlewares/reduction -run 'TestReductionMiddlewareTrunc/test_default_truncation_notice_includes_configured_read_tool_name' -count=1go test ./adk/middlewares/reduction -count=1go test ./adk/middlewares/reduction -coverprofile=/tmp/eino-reduction-1110.cover -covermode=count -count=1go test ./adk/... -count=1git diff --check