This repository was archived by the owner on Apr 22, 2025. It is now read-only.
Fix jeager collector#37
Merged
cfcosta-cloudwalk merged 2 commits intocloudwalk:mainfrom Mar 9, 2023
Merged
Conversation
cfcosta-cloudwalk
approved these changes
Mar 9, 2023
cfcosta-cloudwalk
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jeager collector is expected to be used with an URL. Since version 0.17,
opentelemetry-jeagersplit the agent and collector pipelines.new_agent_pipelineexpects aSocketAddrasendpoint, failing when is provided an url. So, we need to update the function as well.