[sc-12774] remove ledger_id from types based on conserv changes #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRAFT: still having trouble with:
service_account_null_last_used_by test in user_details
every attempt at getting the correct type in the mock data for
chatgpt_threads results in an error (incorrect type or key must be a
string)
Pulling in the new openapi spec from conserv caused a ton of changes :(
Contributor
Author
|
The error as it currently sits:
This seems to be due to the chatgpt_threads being a HashMap and the deserializer (serde) may not handle it? I am definitely at my limits with this one. |
|
@dwdozier does your manual override to the generated client code fix this issue? |
|
Also, can you point me to where you're seeing this error? I don't see it in CI. |
matthewcummings
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: still having trouble with:
service_account_null_last_used_by test in user_details
every attempt at getting the correct type in the mock data for
chatgpt_threads results in an error (incorrect type or key must be a string)
Pulling in the new openapi spec from conserv caused a ton of changes :(