feat: Add datePlaceholder and timePlaceholder props to date-range-picker component's i18nStrings #4104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Who-is-PS
changed the title
src/date-range-picker/interfaces.ts
Outdated
|
|
||
| /** | ||
| * Placeholder text for date inputs in absolute mode. | ||
| * Should match the expected date format (e.g., "YYYY-MM-DD", "JJJJ-MM-TT" for German). |
Member
There was a problem hiding this comment.
use "for example" instead of "e.g."
Member
gethinwebster
left a comment
gethinwebster
left a comment
There was a problem hiding this comment.
"feat:" commits end up in our release notes, so they should include the component name somewhere
Who-is-PS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add configurable
datePlaceholderandtimePlaceholderprops to the date-range-picker component's i18nStrings, allowing developers to customize placeholder text for date and time inputs in absolute mode.Related links, issue #, if available: n/a
AWSUI-61514How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.