chore: update Terraform test matrix - #591
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The workflows’ LATEST_VERSION env values weren’t updated to match the new matrix entries, so the “latest” conditional steps will run against the wrong versions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates CI and developer tooling version matrices to track newer Terraform/OpenTofu releases in this Terraform Provider for Cloud Foundry repository.
Changes:
- Bump Terraform acceptance-test matrix to include Terraform
1.16.*and drop1.13.*. - Update OpenTofu acceptance-test matrix entries and fix the
if:expression syntax in the workflow. - Update devcontainer OpenTofu feature version and refresh the bug-report template Terraform CLI placeholder.
File summaries
| File | Description |
|---|---|
| .github/workflows/test.yml | Updates Terraform CLI test matrix for acceptance tests. |
| .github/workflows/test-opentofu.yml | Updates OpenTofu CLI test matrix and refines conditional execution for “latest” version behavior. |
| .github/ISSUE_TEMPLATE/bug_report.yml | Updates the suggested Terraform CLI version placeholder. |
| .devcontainer/withenvfile/devcontainer.json | Bumps devcontainer OpenTofu feature version. |
| .devcontainer/default/devcontainer.json | Bumps devcontainer OpenTofu feature version. |
Review details
Suppressed comments (1)
.github/workflows/test-opentofu.yml:66
- The OpenTofu matrix now includes 1.12., but env.LATEST_VERSION is still 1.10.. This means the workflow will treat 1.10.* as “latest” (running the go-test-action step) and will not treat 1.12.* as the latest version.
tofu_wrapper: false
- run: go mod download
- run: go test -v -timeout=900s -parallel=4 ./...
if: ${{ matrix.opentofu != env.LATEST_VERSION }}
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
go test ./...What to Check
Verify that the following are valid:
Other Information
n/a
Checklist for reviewer
The following organizational tasks must be completed before merging this PR: