Skip to content

chore: update Terraform test matrix - #591

Merged
ANUGRAHG merged 2 commits into
mainfrom
chore/version
Sep 9, 2026
Merged

ANUGRAHG merged 2 commits into
mainfrom
chore/version

Conversation

@lechnerc77

Copy link
Copy Markdown
Contributor

Purpose

  • Update Terraform test matrix
  • Update dev container config
  • Update OpenTofu test matrix

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe: dve and test setup

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

n/a

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

Copilot AI lite review requested due to automatic review settings September 9, 2026 09:28
@github-actions github-actions Bot added this to the 1.18.0 milestone Sep 9, 2026
@lechnerc77 lechnerc77 modified the milestones: 1.18.0, 1.19.0 Sep 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflows’ LATEST_VERSION env values weren’t updated to match the new matrix entries, so the “latest” conditional steps will run against the wrong versions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates CI and developer tooling version matrices to track newer Terraform/OpenTofu releases in this Terraform Provider for Cloud Foundry repository.

Changes:

  • Bump Terraform acceptance-test matrix to include Terraform 1.16.* and drop 1.13.*.
  • Update OpenTofu acceptance-test matrix entries and fix the if: expression syntax in the workflow.
  • Update devcontainer OpenTofu feature version and refresh the bug-report template Terraform CLI placeholder.
File summaries
File Description
.github/workflows/test.yml Updates Terraform CLI test matrix for acceptance tests.
.github/workflows/test-opentofu.yml Updates OpenTofu CLI test matrix and refines conditional execution for “latest” version behavior.
.github/ISSUE_TEMPLATE/bug_report.yml Updates the suggested Terraform CLI version placeholder.
.devcontainer/withenvfile/devcontainer.json Bumps devcontainer OpenTofu feature version.
.devcontainer/default/devcontainer.json Bumps devcontainer OpenTofu feature version.
Review details

Suppressed comments (1)

.github/workflows/test-opentofu.yml:66

  • The OpenTofu matrix now includes 1.12., but env.LATEST_VERSION is still 1.10.. This means the workflow will treat 1.10.* as “latest” (running the go-test-action step) and will not treat 1.12.* as the latest version.
          tofu_wrapper: false
      - run: go mod download
      - run: go test -v -timeout=900s -parallel=4 ./...
        if: ${{ matrix.opentofu != env.LATEST_VERSION }}
  • Files reviewed: 5/5 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test-opentofu.yml
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

@sachinprajapat06 sachinprajapat06 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ANUGRAHG ANUGRAHG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ANUGRAHG
ANUGRAHG merged commit aa00fbc into main Sep 9, 2026
12 checks passed
@ANUGRAHG
ANUGRAHG deleted the chore/version branch September 9, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants