Configurable http timeout and http response header timeout for azurebs - #183
Merged
Merged
Conversation
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
stephanme
requested changes
Sep 14, 2026
| } | ||
|
|
||
| // preserve the default transport settings from the azure-sdk-for-go runtime package | ||
| transport := http.DefaultTransport.(*http.Transport).Clone() |
Member
There was a problem hiding this comment.
The transport is based on http.DefaultTransport instead of the default transport provided by the Azure SDK which has a tuned configuration (TLS, timeouts, connection pool config).
github-project-automation
Bot
moved this from Inbox
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
…e SDK * as the settings are not publicly exposed, copy the settings from runtime/transport_default_http_client.go
3 tasks
stephanme
requested changes
Sep 16, 2026
stephanme
left a comment
stephanme
left a comment
Member
There was a problem hiding this comment.
Would be nice to detect upstream changes of the default azcore transport configuration.
Didi not find a nice way to do it. Proposals:
- hash the source code of
runtime/transport_default_http_client.go(may lead to false positives) - use AST to detect transport field changes of
runtime/transport_default_http_client.goand our copy
azure sdk updates are consumed fully automatic if ITs succeed. We would not notice and changes in azcore transport configuration.
* test fails if there are changes in runtime/transport_default_http_client.go
Contributor
Author
|
Added test to detect changes in |
stephanme
requested changes
Sep 16, 2026
stephanme
left a comment
stephanme
left a comment
Member
There was a problem hiding this comment.
One final thing: the azure readme should list the new timeout parameters
stephanme
approved these changes
Sep 16, 2026
github-project-automation
Bot
moved this from Waiting for Changes | Open for Contribution
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime/transport_default_http_client.go)