fix/tests: Replace deprecated net/http2 with standard net/http - #587
Merged
Merged
Conversation
hoffmaen
force-pushed
the
fix-test-failures
branch
from
September 14, 2026 13:41
9fd79f8 to
3fa2862
Compare
a18e
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replacing deprecated net/http2 library usage with standard net/http.
staticcheckcurrently fails with net/http2 usage in both the optional github PR test actions, and the concourse unit test pipelineThe verify_staticcheck failure was introduced by commit 4b29308 (bumping golang.org/x/net v0.58.0 → v0.59.0), which deprecated http2.Transport/.TLSClientConfig (SA1019) in favor of the Go 1.24 net/http Protocols API. This PR migrates the affected tests to net/http.
Backward Compatibility
Breaking Change? No
Only affects tests.