fix(gorouter): hash_balance as string (partial revert of #535) - #586
Merged
Merged
Conversation
hoffmaen
previously approved these changes
Sep 14, 2026
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
b1tamara
force-pushed
the
fix-gorouter-hash-balance-as-string-new
branch
from
September 14, 2026 11:43
ae114f8 to
5fb52d1
Compare
Since v0.386.0, gorouter fails to unmarshal `router.register` NATS messages for any route configured with hash-based load balancing (`loadbalancing: hash`) that includes a `hash_balance` factor. The message is rejected as a validation error and dropped, so the endpoint is never registered. The route becomes unreachable (404 / stale until TTL expiry) even though the app and the registration message are healthy. This restores the old parsing. Co-authored-by: Alexander Nicke <alexander.nicke@sap.com>
b1tamara
force-pushed
the
fix-gorouter-hash-balance-as-string-new
branch
from
September 14, 2026 12:04
5fb52d1 to
3bbe816
Compare
hoffmaen
approved these changes
Sep 14, 2026
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR
hash_balance. The,stringsuffix was removed as part of https://github.com/cloudfoundry/routing-release/pull/535/changes#diff-a3cb8cde907ca8ef9a573547cc9464f3bfa9348ce3beedcb838e768d40a99c85L46, which broke hash-based routing.Backward Compatibility
Breaking Change?
No, fixes (unintended?) breaking change.
See #585