Fix test flakes #4296
Merged
Fix test flakes #4296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly invoke the manager cancel function in `AfterEach`. While doing that in `DeferCleanup` is technically correct, the code looks weird and could raise some eyebrows
danail-branekov
force-pushed
the
fix-flakes
branch
from
2972064 to
eb1ef24
Compare
Our tests start the k8s manager in a separate thread as `k8sManager.Start()` blocks while the manager is running. Once we start the manager, we check whether it is up by invoking its webhook server started check. We have been experiencing flakes caused by the webhook server failing to start within a second, for example https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-main/builds/1896 The interesting thing is that the failure is always in the `controllers/services/osbapi` suite. What distinguishes this suite from the rest of the suites is that it does NOT configure a default eventually timeout, hence the default (one second) is used. One second seems to be insufficient, therefore hardcode the webhook server check timeout to a minute.
danail-branekov
force-pushed
the
fix-flakes
branch
from
eb1ef24 to
c0cb795
Compare
georgethebeatle
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Allow up to a minute for the k8s manager to start
Our tests start the k8s manager in a separate thread as
k8sManager.Start()blocks while the manager is running. Once we startthe manager, we check whether it is up by invoking its webhook server
started check.
We have been experiencing flakes caused by the webhook server failing to
start within a second, for example
https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-main/builds/1896
The interesting thing is that the failure is always in the
controllers/services/osbapisuite. What distinguishes this suite fromthe rest of the suites is that it does NOT configure a default
eventually timeout, hence the default (one second) is used. One second
seems to be insufficient, therefore hardcode the webhook server check
timeout to a minute.
Tag your pair, your PM, and/or team
@georgethebeatle @uzabanov