Use golang/protobuf instead of gogo/protobuf #992
Draft
+12,395
−39,430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go mod tidy && go mod vendor Bump bbs (merge issues) Fix issues from linters
Bump executor (staticcheck SetNproc) Remove golang 1.22
Submodule src/code.cloudfoundry.org/credhub-cli 329c0d63b..5af5e1820: > Bump go modules
-------- index d7b4323..c7626ce 100644 @@ -18,31 +18,31 @@ replace ( code.cloudfoundry.org/archiver v0.26.0 - code.cloudfoundry.org/bytefmt v0.28.0 + code.cloudfoundry.org/bytefmt v0.29.0 code.cloudfoundry.org/cacheddownloader v0.0.0-20241210011823-7ae5910b9f48 - code.cloudfoundry.org/certsplitter v0.38.0 - code.cloudfoundry.org/cf-routing-test-helpers v0.0.0-20241025163157-ce30ff0fff6d + code.cloudfoundry.org/certsplitter v0.39.0 + code.cloudfoundry.org/cf-routing-test-helpers v0.0.0-20250205194842-92b089ca98e3 code.cloudfoundry.org/cf-tcp-router v0.0.0-20241025163552-3216bbbc1656 - code.cloudfoundry.org/cfhttp/v2 v2.33.0 + code.cloudfoundry.org/cfhttp/v2 v2.34.0 code.cloudfoundry.org/clock v1.28.0 code.cloudfoundry.org/cnbapplifecycle v0.0.5 - code.cloudfoundry.org/credhub-cli v0.0.0-20250203140928-329c0d63b022 - code.cloudfoundry.org/debugserver v0.36.0 - code.cloudfoundry.org/diego-logging-client v0.41.0 - code.cloudfoundry.org/dockerdriver v0.36.0 - code.cloudfoundry.org/durationjson v0.29.0 - code.cloudfoundry.org/eventhub v0.28.0 + code.cloudfoundry.org/credhub-cli v0.0.0-20250210140307-5af5e1820968 + code.cloudfoundry.org/debugserver v0.37.0 + code.cloudfoundry.org/diego-logging-client v0.42.0 + code.cloudfoundry.org/dockerdriver v0.37.0 + code.cloudfoundry.org/durationjson v0.30.0 + code.cloudfoundry.org/eventhub v0.29.0 code.cloudfoundry.org/garden v0.0.0-20250204164024-2360009b9575 code.cloudfoundry.org/go-loggregator/v9 v9.2.1 - code.cloudfoundry.org/goshims v0.59.0 - code.cloudfoundry.org/guardian v0.0.0-20250203212249-209fc11dcd6b - code.cloudfoundry.org/lager/v3 v3.25.0 - code.cloudfoundry.org/localip v0.29.0 - code.cloudfoundry.org/tlsconfig v0.17.0 + code.cloudfoundry.org/goshims v0.60.0 + code.cloudfoundry.org/guardian v0.0.0-20250205022619-e7a0755c4c24 + code.cloudfoundry.org/lager/v3 v3.26.0 + code.cloudfoundry.org/localip v0.30.0 + code.cloudfoundry.org/tlsconfig v0.18.0 github.com/GaryBoone/GoStats v0.0.0-20130122001700-1993eafbef57 github.com/ajstarks/svgo v0.0.0-20211024235047-1546f124cd8b github.com/aws/aws-sdk-go v1.55.6 - github.com/awslabs/amazon-ecr-credential-helper/ecr-login v0.0.0-20250127194757-14dfc70fe71c + github.com/awslabs/amazon-ecr-credential-helper/ecr-login v0.0.0-20250206222449-6540026091fe github.com/cactus/go-statsd-client v3.1.1-0.20161031215955-d8eabe07bc70+incompatible github.com/cespare/xxhash/v2 v2.3.0 github.com/cloudfoundry-community/go-uaa v0.3.3 github.com/ghodss/yaml v1.0.0 github.com/go-sql-driver/mysql v1.8.1 github.com/go-test/deep v1.1.1 - github.com/gogo/protobuf v1.3.2 github.com/golang-jwt/jwt/v4 v4.5.1 github.com/golang/protobuf v1.5.4 github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 github.com/mitchellh/hashstructure v1.1.0 github.com/moby/term v0.5.2 github.com/nats-io/nats-server/v2 v2.10.25 - github.com/nats-io/nats.go v1.38.0 + github.com/nats-io/nats.go v1.39.0 github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d github.com/onsi/ginkgo/v2 v2.22.2 github.com/onsi/gomega v1.36.2 github.com/tedsuo/ifrit v0.0.0-20230516164442-7862c310ad26 github.com/tedsuo/rata v1.0.0 github.com/vito/go-sse v1.1.2 - golang.org/x/crypto v0.32.0 - golang.org/x/net v0.34.0 - golang.org/x/oauth2 v0.25.0 + golang.org/x/crypto v0.33.0 + golang.org/x/net v0.35.0 + golang.org/x/oauth2 v0.26.0 golang.org/x/sys v0.30.0 - golang.org/x/time v0.9.0 + golang.org/x/time v0.10.0 google.golang.org/grpc v1.70.0 - google.golang.org/protobuf v1.36.4 + google.golang.org/protobuf v1.36.5 gopkg.in/yaml.v2 v2.4.0 gopkg.in/yaml.v3 v3.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gogo/protobuf has been deprecated for years. We should be using up-to-date protobufs provided by google.golang.org/protobuf. In order to fit our use cases, a protobuf plugin (
protoc-gen-go-bbs) has been created to catch any customizations we want to add.Submodule Pull Requests (please do these first)
cloudfoundry/auctioneer#20
cloudfoundry/bbs#109
cloudfoundry/cfdot#14
cloudfoundry/executor#116
cloudfoundry/inigo#50
cloudfoundry/locket#27
cloudfoundry/rep#67
cloudfoundry/route-emitter#50
cloudfoundry/routing-api#69
cloudfoundry/routing-info#8
cloudfoundry/vizzini#15
Backward Compatibility
Breaking Change? No