Repository navigation
Conversation
…entity-aware-routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…entity-aware-routing
Please take a moment to review the questions before submitting the PR
🚫 We only accept PRs to develop branch. If this is an exception, please specify why 🚫
WHAT is this change about?
Changes
tls_pem/-(append) totls_pem/1?(upsert) inoperations/enable-identity-aware-routing.ymlto fix anincompatibility with
operations/use-operator-provided-router-tls-certificates.yml.What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
The experimental pipeline can't deploy cf-deployment with both
enable-identity-aware-routing.ymlanduse-operator-provided-router-tls-certificates.ymlapplied together. BOSH interpolation fails with:Expected to find an array at path '.../tls_pem/-' but found 'string'https://concourse.wg-ard.ci.cloudfoundry.org/teams/main/pipelines/cf-deployment/jobs/experimental-deploy/builds/2542
Please provide any contextual information.
use-operator-provided-router-tls-certificates.ymlreplaces thetls_pemarray with an unresolved variable reference((router_tls_pem)). At BOSH interpolation time,/-(append) cannot operate on an unresolved variable reference andfails.
/1?(upsert) resolves after the variable is evaluated, so it works in both cases:tls_pemis a single-entry array → upsert adds at index 1((router_tls_pem))is resolved to an array first → upsert adds at index 1Related PRs:
enable-identity-aware-routing.ymlHas a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change?
How should this change be described in cf-deployment release notes?
Fixes
enable-identity-aware-routing.ymlcompatibility withuse-operator-provided-router-tls-certificates.ymlso Codycan use both ops-files together without BOSH interpolation errors.
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
Tag your pair, your PM, and/or team!