Skip to content

fix (new) govet compile breakage / lint errors - #192

Merged
aramprice merged 1 commit into
windows-2019from
fix-linter-issues
Sep 16, 2026
Merged

aramprice merged 1 commit into
windows-2019from
fix-linter-issues

Conversation

@aramprice

Copy link
Copy Markdown
Member

addresses:

non-constant format string in call to (github.com/cloudfoundry/bosh-windows-stemcell-builder/stembuild/colorlogger.Logger).Printf

addresses:
```
non-constant format string in call to (github.com/cloudfoundry/bosh-windows-stemcell-builder/stembuild/colorlogger.Logger).Printf
```
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 85cc22f0-66b7-4fbe-a71c-222b62c0af5b

📥 Commits

Reviewing files that changed from the base of the PR and between 49f9c7a and 45f6a9b.

📒 Files selected for processing (1)
  • stembuild/colorlogger/colorlogger_test.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

Three logger tests now pass their messages to Printf through an explicit %s format string. The expected output assertions remain unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 45f6a

The updated tests use explicit format strings without changing their expected output, so the PR is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title identifies the govet compile and lint errors addressed by the changes to Logger.Printf test calls.
Description check ✅ Passed The description directly identifies the non-constant format string warning fixed by the changeset.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-linter-issues

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aramprice aramprice changed the title fix (new) linter errors fix (new) govet compile breakage / lint errors Sep 16, 2026
@aramprice
aramprice merged commit 9303409 into windows-2019 Sep 16, 2026
15 checks passed
@aramprice
aramprice deleted the fix-linter-issues branch September 16, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants