Skip to content

fix: add bpm to test deployment manifests#167

Merged
aramprice merged 1 commit into
masterfrom
add-bpm-to-tests
Jul 6, 2026
Merged

fix: add bpm to test deployment manifests#167
aramprice merged 1 commit into
masterfrom
add-bpm-to-tests

Conversation

@mkocher

@mkocher mkocher commented Jul 6, 2026

Copy link
Copy Markdown
Member

bpm requirement was added in #166

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 43875787-43f1-494c-a188-a2648b16b389

📥 Commits

Reviewing files that changed from the base of the PR and between 0f6ca50 and c0bb939.

📒 Files selected for processing (2)
  • ci/assets/test-stress/bosh-workspace/deployments/bosh-dns.yml
  • src/bosh-dns/test_yml_assets/manifests/dns-linux.yml

Walkthrough

Two BOSH deployment manifest files were modified to add a bpm job entry under instance_groups.jobs and a corresponding bpm release declaration (version latest) under the releases section. Changes were applied to ci/assets/test-stress/bosh-workspace/deployments/bosh-dns.yml and src/bosh-dns/test_yml_assets/manifests/dns-linux.yml.

Changes

Cohort / File Change Summary
ci/assets/test-stress/bosh-workspace/deployments/bosh-dns.yml Added bpm job to instance_groups.jobs; added bpm release (version latest) to releases
src/bosh-dns/test_yml_assets/manifests/dns-linux.yml Added bpm job to instance_groups.jobs; added bpm release (version latest) to releases

Suggested reviewers: aramprice

🐰 A hop, a skip, a bpm job appears,
Nestled among the jobs of past years,
Release lists grow by one small line,
Manifests updated, all in fine line,
Two files now sing the same refrain.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: adding bpm to test deployment manifests.
Description check ✅ Passed The description is related to the change and explains it was driven by the bpm requirement in #166.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-bpm-to-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aramprice aramprice merged commit e771e2a into master Jul 6, 2026
22 checks passed
@aramprice aramprice deleted the add-bpm-to-tests branch July 6, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants